Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debug view state is not preserved if it is not visible between reloads #5815

Closed
akosyakov opened this issue Jul 30, 2019 · 2 comments · Fixed by #5817
Closed

debug view state is not preserved if it is not visible between reloads #5815

akosyakov opened this issue Jul 30, 2019 · 2 comments · Fixed by #5817
Assignees
@akosyakov
Labels
bug bugs found in the application debug issues that related to debug functionality

Comments

@akosyakov
Copy link
Member

akosyakov commented Jul 30, 2019 •
edited
Loading

It's a regression. It was fixed in #5665 I will prepare a PR which includes the fix commit from #5665
@akosyakov akosyakov added bug bugs found in the application debug issues that related to debug functionality labels Jul 30, 2019
@akosyakov akosyakov self-assigned this Jul 30, 2019
@akosyakov
Copy link
Member Author

Also breakpoints are never recovered.

@akosyakov
Copy link
Member Author

Actually debug views are never rendered properly on reload. It does not matter whether they were visible or not.

akosyakov added a commit that referenced this issue Jul 30, 2019
@akosyakov
fix #5815: preserve last visible view container state
64af433 
otherwise collapsed view containers are not restored

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
@akosyakov akosyakov mentioned this issue Jul 30, 2019
Merged
1 task
akosyakov added a commit that referenced this issue Jul 31, 2019
@akosyakov
fix #5815: preserve last visible view container state
d294062 
otherwise collapsed view containers are not restored

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Jul 31, 2019
@akosyakov
fix #5815: preserve last visible view container state
46a1da6 
otherwise collapsed view containers are not restored

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akosyakov akosyakov

Labels
bug bugs found in the application debug issues that related to debug functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

preserve debug view layout eclipse-theia/theia
1 participant
@akosyakov