Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support input variable substitution for tasks #5836

Closed
akosyakov opened this issue Aug 1, 2019 · 5 comments · Fixed by #6331
Closed

support input variable substitution for tasks #5836

akosyakov opened this issue Aug 1, 2019 · 5 comments · Fixed by #6331
Assignees
@elaihau
Labels
preferences issues related to preferences tasks issues related to the task system vscode issues related to VSCode compatibility

Comments

@akosyakov
Copy link
Member

akosyakov commented Aug 1, 2019 •
edited by elaihau
Loading

It's a follow-up of #5835. It depends on #5013.

cc @marcdumais-work @elaihau @vince-fugnitto
@akosyakov akosyakov added preferences issues related to preferences tasks issues related to the task system vscode issues related to VSCode compatibility labels Aug 1, 2019
@akosyakov akosyakov mentioned this issue Aug 1, 2019
Merged
2 tasks
@metlos metlos mentioned this issue Aug 8, 2019
Closed
@elaihau
Copy link
Contributor

elaihau commented Sep 6, 2019 •
edited
Loading

@akosyakov
could you please explain the reason that this one is dependent on #5013 ?

please correct me if i am wrong:
i believe we can support the input section in tasks.json and variable substitution even if tasks are not accessible from the configuration / preference. Having it is just one more round of "resolving task configuration".

@akosyakov
Copy link
Member Author

@elaihau sorry i cannot remember already, probably I thought it would be easier to implement if tasks will be loaded through preferences, or did not want to implement it before refactoring loading via preferences to avoid double work

@elaihau elaihau self-assigned this Sep 26, 2019
@marcdumais-work marcdumais-work mentioned this issue Oct 4, 2019
Closed
elaihau pushed a commit that referenced this issue Oct 4, 2019
support input variables for tasks
5c154ec 
- add support to input variables which have the syntax: ${input:variableID}, where the variableID refers to entries in the inputs section of `tasks.json`.
- resolves #5836

Signed-off-by: Liang Huang <liang.huang@ericsson.com>
@elaihau elaihau mentioned this issue Oct 4, 2019
Merged
1 task
elaihau pushed a commit that referenced this issue Oct 6, 2019
@elaihau
support input variables for tasks
0f7fc56 
- add support to input variables which have the syntax: ${input:variableID}, where the variableID refers to entries in the inputs section of `tasks.json`.
- resolves #5836

Signed-off-by: Liang Huang <liang.huang@ericsson.com>
@akosyakov
Copy link
Member Author

Content assist for input variables still don't work in tasks.json. It should work the same way as for launch configurations.

@akosyakov akosyakov reopened this Oct 6, 2019
@elaihau
Copy link
Contributor

elaihau commented Oct 7, 2019

Could this one be closed as #6334 is merged？

@akosyakov
Copy link
Member Author

Sure

akosyakov pushed a commit to akosyakov/theia that referenced this issue Feb 24, 2020
@akosyakov
support input variables for tasks
bf43ce3 
- add support to input variables which have the syntax: ${input:variableID}, where the variableID refers to entries in the inputs section of `tasks.json`.
- resolves eclipse-theia#5836

Signed-off-by: Liang Huang <liang.huang@ericsson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elaihau elaihau

Labels
preferences issues related to preferences tasks issues related to the task system vscode issues related to VSCode compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

support input variables for tasks eclipse-theia/theia
2 participants
@akosyakov @elaihau