New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add configurable clean for .theia/logs folder. #6866
Comments
@ira-gordin-sap |
I don't know the current behavior in VS Code. |
@ira-gordin-sap when testing, which plugins were you using? |
@vince-fugnitto I am implementing log in my VS code extension. |
Thank you for investigating further and following up. |
Are these APIs available directly in Theia or should alternatives be used? import { IEnvironmentService } from 'vs/platform/environment/common/environment';
import { join, dirname, basename } from 'vs/base/common/path';
import { readdir, rimraf } from 'vs/base/node/pfs';
import { onUnexpectedError } from 'vs/base/common/errors';
import { Disposable, toDisposable } from 'vs/base/common/lifecycle'; |
Looking at the code previously referenced, there does not seem to be anything preventing getting the feature to work properly. There are definitely internal Theia methods and APIs that can be used to compliment the feature. Please note that if a straight copy+paste cannot be used, you can always inspire yourself from their implementation. |
I would very much like to handle. Waiting for approval from my product owner. |
Sounds great! |
Hello. I have a fix here: However I have reservations regarding the Eclipse Foundation Licensing.
Does providing a Physical Postal Address Mandatory to Sign the eclipse ECA? |
Could my Employer's (who I am making the contribution on behalf of) address be provided? |
@marcdumais-work perhaps you can help regarding the Eclipse ECA questions? |
Hi @bd82,
First I do not speak for the Eclipse Foundation and IINAL. If you feel the need, we can involve someone from the foundation to get a more definitive answer. Looking at my own ECA, I provided the address of my employer, so I think that's fine if you contribute in the context of your work. As far as I know, the country of your employer being different from your own would not matter - your employer's address is what it is. |
O.k. sounds good enough. I will continue creating the PR tomorrow. Cheers. |
o.k. I used my employer's physical address. A PR was created: #6956 This could be used as a stepping stone to include also configurable options: e.g:
Cheers. |
The ECA check on your PR passed, so you're all set |
By default n===10. N is Configurable using `--plugin-max-session-logs-folders=N` CLI option. fixes #6866 Signed-off-by: I060847 <shachar.soel@sap.com>
By default n===10. N is Configurable using `--plugin-max-session-logs-folders=N` CLI option. fixes eclipse-theia#6866 Signed-off-by: I060847 <shachar.soel@sap.com>
By default n===10. N is Configurable using `--plugin-max-session-logs-folders=N` CLI option. fixes eclipse-theia#6866 Signed-off-by: I060847 <shachar.soel@sap.com>
Description
.theia/logs folder is not cleaned.
Reproduction Steps
Create VS code extension which writes logs to context.logPath received in activate() method.
In my VS Code extension I have:
export function activate(context: vscode.ExtensionContext).
The value of context.logPath on my environment is .theia/logs/20200109T092254/host/.. I use this folder to create my logs files there.
OS and Theia version:
OS: Linux
Theia version: v0.14.0
Diagnostics:
"ls .theia/logs/" shows many folders named as timestamps like 20200109T092254. Currently I see that the oldest one is from the time I created my container.
The text was updated successfully, but these errors were encountered: