Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support VS Code Standard Icons in Contributions #7634

Closed
akosyakov opened this issue Apr 21, 2020 · 3 comments · Fixed by #8267
Closed

Support VS Code Standard Icons in Contributions #7634

akosyakov opened this issue Apr 21, 2020 · 3 comments · Fixed by #8267
Assignees
@akosyakov
Labels
bug bugs found in the application plug-in system issues related to the plug-in system vscode issues related to VSCode compatibility

Comments

@akosyakov
Copy link
Member

akosyakov commented Apr 21, 2020 •
edited by vince-fugnitto
Loading

It is reproducible with https://github.com/microsoft/vscode-java-test:
Screenshot 2020-04-21 at 13 01 28

URLs like hostedPlugin/vscjava_vscode_java_test/%24(refresh). It seems to be that it is not a path, but rather codicons.
@akosyakov akosyakov added bug bugs found in the application help wanted issues meant to be picked up, require help vscode issues related to VSCode compatibility java issues related to the java language labels Apr 21, 2020
@veredcon veredcon mentioned this issue Jun 15, 2020
Closed
@akosyakov akosyakov mentioned this issue Jun 15, 2020
Closed
@akosyakov akosyakov removed the java issues related to the java language label Jun 15, 2020
@tsmaeder tsmaeder changed the title some plugin icons cannot be fetched Support VS Code Standard Icons in Contributions Jul 27, 2020
@tsmaeder tsmaeder added the plug-in system issues related to the plug-in system label Jul 27, 2020
@tsmaeder
Copy link
Contributor

The well-know icons are described in the documentation: https://code.visualstudio.com/api/references/icons-in-labels

I've taken the liberty of updating the title; I think it better describes the issue.

@thisHermit thisHermit mentioned this issue Jul 27, 2020
Closed
@tsmaeder tsmaeder mentioned this issue Jul 27, 2020
Open
@akosyakov
Copy link
Member Author

@tsmaeder Are you fine if I look at it or you were planning?

@tsmaeder
Copy link
Contributor

Please do, @akosyakov

@akosyakov akosyakov removed the help wanted issues meant to be picked up, require help label Jul 29, 2020
@akosyakov akosyakov self-assigned this Jul 29, 2020
@akosyakov akosyakov mentioned this issue Jul 29, 2020
Closed
akosyakov added a commit that referenced this issue Jul 29, 2020
@akosyakov
[vscode] fix #7634: support theme icons
f35a67b 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Jul 30, 2020
@akosyakov
[vscode] fix #7634: support theme icons
14ff865 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
@akosyakov akosyakov mentioned this issue Jul 30, 2020
Merged
1 task
akosyakov added a commit that referenced this issue Jul 30, 2020
@akosyakov
[vscode] fix #7634: support theme icons
d7b98f0 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Jul 30, 2020
@akosyakov
[vscode] fix #7634: support theme icons
c6735b7 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
minyoungyang pushed a commit to minyoungyang/theia that referenced this issue Aug 4, 2020
@akosyakov @minyoungyang
[vscode] fix eclipse-theia#7634: support theme icons
007cbd0 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akosyakov akosyakov

Labels
bug bugs found in the application plug-in system issues related to the plug-in system vscode issues related to VSCode compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[vscode] support theme icons eclipse-theia/theia
2 participants
@akosyakov @tsmaeder