Build fails when downloading built-ins #9014
Comments
|
+1
|
|
The oldest version of the built-ins I find in open-vsx is 1 .45.1. |
|
I have noticed it as well. If I got it correctly from an internal chat, the Eclipse Publisher Agreement is mandatory for the extensions. All the extensions that were not signed, are not available anymore although they're still in the Azure blob. For example, https://open-vsx.org/api/vscode/cpp/1.44.2/file/vscode.cpp-1.44.2.vsix was missing for me, but it's still under https://openvsxorg.blob.core.windows.net/resources/vscode/cpp/1.44.2/vscode.cpp-1.44.2.vsix |
|
@marcdumais-work could it be that version |
Let's try that. I'll setup, make sure this version still builds and report back |
|
v1.44.2 looks to still build ok. @spoenemann How do we proceed? I think I can use |
|
|
What it does Fixes [eclipse-theia#9014] - Update necessary built-ins to version 1.45.1 Signed-off-by: seantan22 <sean.a.tan@ericsson.com>
What it does Fixes [eclipse-theia#9014] - Update necessary built-ins to version 1.45.1 Signed-off-by: seantan22 <sean.a.tan@ericsson.com>
Thank you for your Pull Request. Please provide a description and review the requirements below. Contributors guide: https://github.com/theia-ide/theia/blob/master/CONTRIBUTING.md --> <!-- Include relevant issues and describe how they are addressed. --> Fixes [eclipse-theia#9014] - Update necessary built-ins to version 1.45.1 <!-- Explain how a reviewer can reproduce a bug, test new functionality or verify performance improvements. --> 1. `git clone https://github.com/eclipse-theia/theia` 2. `cd theia` 3. `yarn` Confirm that all built-ins are successfully downloaded. - [x] as an author, I have thoroughly tested my changes and carefully followed [the review guidelines](https://github.com/theia-ide/theia/blob/master/doc/pull-requests.md#requesting-a-review) - as a reviewer, I agree to behave in accordance with [the review guidelines](https://github.com/theia-ide/theia/blob/master/doc/pull-requests.md#reviewing) Signed-off-by: seantan22 <sean.a.tan@ericsson.com> Signed-off-by: seantan22 <sean.a.tan@ericsson.com>
<!-- Thank you for your Pull Request. Please provide a description and review the requirements below. Contributors guide: https://github.com/theia-ide/theia/blob/master/CONTRIBUTING.md --> <!-- Include relevant issues and describe how they are addressed. --> Fixes [eclipse-theia#9014] - Update necessary built-ins to version 1.45.1 <!-- Explain how a reviewer can reproduce a bug, test new functionality or verify performance improvements. --> 1. `git clone https://github.com/eclipse-theia/theia` 2. `cd theia` 3. `yarn` Confirm that all built-ins are successfully downloaded. - [x] as an author, I have thoroughly tested my changes and carefully followed [the review guidelines](https://github.com/theia-ide/theia/blob/master/doc/pull-requests.md#requesting-a-review) - as a reviewer, I agree to behave in accordance with [the review guidelines](https://github.com/theia-ide/theia/blob/master/doc/pull-requests.md#reviewing) Signed-off-by: seantan22 <sean.a.tan@ericsson.com> Signed-off-by: seantan22 <sean.a.tan@ericsson.com>
<!-- Thank you for your Pull Request. Please provide a description and review the requirements below. Contributors guide: https://github.com/theia-ide/theia/blob/master/CONTRIBUTING.md --> <!-- Include relevant issues and describe how they are addressed. --> Fixes [eclipse-theia#9014] - Update necessary built-ins to version 1.45.1 <!-- Explain how a reviewer can reproduce a bug, test new functionality or verify performance improvements. --> 1. `git clone https://github.com/eclipse-theia/theia` 2. `cd theia` 3. `yarn` Confirm that all built-ins are successfully downloaded. - [x] as an author, I have thoroughly tested my changes and carefully followed [the review guidelines](https://github.com/theia-ide/theia/blob/master/doc/pull-requests.md#requesting-a-review) - as a reviewer, I agree to behave in accordance with [the review guidelines](https://github.com/theia-ide/theia/blob/master/doc/pull-requests.md#reviewing) Signed-off-by: seantan22 <sean.a.tan@ericsson.com>
What it does Fixes [eclipse-theia#9014] - Update necessary built-ins to version 1.45.1 How to test 1. `git clone https://github.com/eclipse-theia/theia` 2. `cd theia` 3. `yarn` Confirm that all built-ins are successfully downloaded. Signed-off-by: seantan22 <sean.a.tan@ericsson.com>
What it does Fixes [#9014] - Update necessary built-ins to version 1.45.1 How to test 1. `git clone https://github.com/eclipse-theia/theia` 2. `cd theia` 3. `yarn` Confirm that all built-ins are successfully downloaded. Signed-off-by: seantan22 <sean.a.tan@ericsson.com>
|
The immediate build problem for our example application was fixed by switching to a slightly newer version of the vscode-builtins. To restore the v1.44.2 for others who may be using it, we can still re-publish v1.44.2 and are very close. I think we just need to remove the original extensions of that version from open-vsx.org and re-trigger the publish. See: @spoenemann WDYT? |
|
Yes I can remove those versions (and also all older versions?) I would do that for all extensions in the The extensions can be listed here: |
|
@spoenemann yes, please proceed at your conveinence. |
Yes, I think so. I guess any that were published by me (under my GH user) |
|
I deleted |
|
@spoenemann @marcdumais what should the policy be in the future with respect to old version of the built-ins in open-vsx? |
|
Generally we want to keep all old versions. We might consider deleting very old |
Thanks Miro. I will attempt to republish builtins |
This has been done |
Bug Description:
A build of master fails on the step where the built-ins are downloaded with these messages:
I suspect some extension versions have been purged from open-vsx
Steps to Reproduce:
Additional Information
Using the browser to download a missing built-in extension (
https://open-vsx.org/api/vscode/java/1.44.2/file/vscode.java-1.44.2.vsix) shows that the extension is indeed missing.The text was updated successfully, but these errors were encountered: