remove upper range on Node.js version #10343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a low risk change, and it can fit in today's release. It will lighten some of the load for me for release after that. |
paul-marechal
force-pushed
the
mp/node-14
branch
from
4faef1a
to
cf60e71
Compare
vince-fugnitto
approved these changes
Oct 28, 2021
Support at least Node.js 12 but remove the upper-bound. Downstream projects should be able to choose their own Node.js version based on their needs. The framework still expects to run on Node.js 12 at the minimum. Using a previous version might lead to errors due to our usage of APIs that might be missing in earlier versions. Electron is not updated in this commit but it should be done sooner than later. Note that one of dependency `dugite-extra` has its own Node.js range that may prevent using Node.js newer than 12. This only affects downstream projects that include the `@theia/git` extension. You can still get around it by running `yarn --ignore-engines <command...>`. Add `doc/runtime-policy.md`. Update `doc/Developing.md` to reflect the policy. Update CI to run on Node 12 and 14.
paul-marechal
force-pushed
the
mp/node-14
branch
from
cf60e71
to
cab202c
Compare
And we should, for now. But starting with 1.19.0 it should be slightly easier to use Node 14 and it prepares the repository for the Electron upgrade. It also documents the policy we will be going forward with. |
|
CI error is unrelated. |
NexediGitlab
pushed a commit
to SlapOS/slapos
that referenced
this pull request
Dec 12, 2021
Since eclipse-theia/theia#10343 theia depend on nodejs >= 12 and they test on 12 and 14. Use 14 to have an officially tested version. This removes the strong requirement to have python2.7 in theia, so we just use the software python, which might be python3
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support at least Node.js 12 but remove the upper-bound. Downstream
projects should be able to choose their own Node.js version based on
their needs. The framework still expects to run on Node.js 12 at the
minimum. Using a previous version might lead to errors due to our usage
of APIs that might be missing in earlier versions.
Electron is not updated in this commit but it should be done sooner than
later.
Note that one of dependency
dugite-extrahas its own Node.js rangethat may prevent using Node.js newer than 12. This only affects
downstream projects that include the
@theia/gitextension. You canstill get around it by running
yarn --ignore-engines <command...>.Add
doc/runtime-policy.md.Update
doc/Developing.mdto reflect the policy.Update CI to run on Node 12 and 14.
Closes #9878.
How to test
Build and run using Node 12 and 14.
You may need to run
yarn --ignore-enginesbecause ofdugite-extra.CI should be green.
Review checklist
Reminder for reviewers