Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Themes #10525

Merged
merged 1 commit into from
Feb 24, 2022
Merged

Update Themes #10525

merged 1 commit into from
Feb 24, 2022

Conversation

colin-grant-work
Copy link
Contributor

@colin-grant-work colin-grant-work commented Dec 9, 2021

What it does

Updates the specification of our default themes to match recent VSCode.

How to test

  1. Open a TS file.
  2. Move through the built-in themes.
  3. Observe that they behave as expected.

Review checklist

CQ: https://dev.eclipse.org/ipzilla/show_bug.cgi?id=23884

Reminder for reviewers

@colin-grant-work colin-grant-work added CQ Required (deprecated) issues requiring a CQ (contributor questionnaire) dependencies pull requests that update a dependency file labels Dec 9, 2021
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updated themes look good. I could not notice any regressions 👍

Has the related CQ already been approved? Do you mind linking it?

@colin-grant-work
Copy link
Contributor Author

@msujew, I'm having a lot of trouble accessing the CQ - changed my password several times, but still can't log into Bugzilla. I'll try to resolve it with the Eclipse Foundation, but in the meantime, I've put the link in the description...

@ccorn
Copy link

ccorn commented Jan 26, 2022

greping through package.json for theme leads me to this question:

What about vscode.vscode-theme-seti? That one has not been updated.
(I suppose that there is a reason. Just asking.)

@colin-grant-work
Copy link
Contributor Author

@ccorn, this was related to work on semantic colorization, and file themes were not part of that work.

@JonasHelming
Copy link
Contributor

@colin-grant-work CQ is approved ;-)

@colin-grant-work
Copy link
Contributor Author

@colin-grant-work CQ is approved ;-)

@JonasHelming, thanks for the heads up, and thanks for pushing it through! 🙏

@colin-grant-work colin-grant-work merged commit 1de4a37 into master Feb 24, 2022
@colin-grant-work colin-grant-work deleted the update/built-in-themes branch February 24, 2022 18:24
@github-actions github-actions bot added this to the 1.23.0 milestone Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CQ Required (deprecated) issues requiring a CQ (contributor questionnaire) dependencies pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants