Fix showOpenDialog fallback #10573
Merged
Fix showOpenDialog fallback #10573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The showOpenDialog and other file dialog extension APIs now correctly fall back to the workspace root when a defaultUri is not provided. Signed-off-by: Matthew Gordon <matthew.gordon@arm.com>
colin-grant-work
added
bug
colin-grant-work
approved these changes
Dec 22, 2021
mcgordonite
added a commit
to ARMmbed/theia
that referenced
this pull request
Dec 23, 2021
The showOpenDialog and other file dialog extension APIs now correctly fall back to the workspace root when a defaultUri is not provided. Signed-off-by: Matthew Gordon <matthew.gordon@arm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #10572 by correcting logic in the plugin extension. The
showOpenDialogand other file dialog extension APIs now correctly fall back to the workspace root when thedefaultUriis not specified.How to test
Fallback to the workspace root when a
defaultUriis not specified can be tested with the vscode-xml extension as described in #10572.The behaviour when a
defaultUriis present can be tested as described in #7451. In this case, the file dialog should open at the parent folder when a file is passed as thedefaultUri.Review checklist
Reminder for reviewers