Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render notification progress update as html #10588

Merged
merged 1 commit into from
Jan 5, 2022
Merged

Conversation

msujew
Copy link
Member

@msujew msujew commented Jan 3, 2022

What it does

Closes #10587
Addresses one issue from #10579

Renders the message of a progress update also to html. Additionally, allows to include unknown protocols in hrefs, which previously lead to command:some-command hrefs from being removed by DOMPurify.

How to test

  1. Install the RedHat Java extension and open a Java Project.
  2. Wait until the "Opening Java Projects" notification appears.
  3. Click the link, "check details", which should run the java.show.server.task.status command. (be fast, the notification disappears quite quickly)

Review checklist

Reminder for reviewers

@msujew msujew added the notifications issues related to notifications label Jan 3, 2022
Copy link
Contributor

@colin-grant-work colin-grant-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me and resolve the issue described.

@msujew msujew merged commit 8083f76 into master Jan 5, 2022
@msujew msujew deleted the msujew/progress-markdown branch January 5, 2022 15:30
@vince-fugnitto vince-fugnitto added this to the 1.22.0 milestone Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notifications issues related to notifications
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Markdown in notification progress update is not rendered to html
3 participants