Console History is not trimmed to maximum

[JonasHelming]

Bug Description:

The history of commands typed in the debug console will not be capped at the intended limit (50), but grows forever).

Steps to Reproduce:

1. To test, ideally first lower the limit from 50 to something lower, e.g. 3 in:

   theia/packages/console/src/browser/console-history.ts

   Line 22 in 8083f76

   static limit = 50;

2. Open Theia and the debug console.
3. Execute more commands then the limit (e.g. 4)
4. Press arrow up and see that more commands than then limit are stored in the history

Additional Information

Looks like the history array is sliced correctly in the trim function, but the return value is ignored. The return value should be assigned to the original array, see

theia/packages/console/src/browser/console-history.ts

Line 42 in 8083f76

this.values.slice(index);