Console: Fixed issues involving Console History not being capped at specified limit, regarding Issue #10598 #11162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…trimmed to maximum, Issue was fixed by assigning trimmed array to original array; Signed-off-by: Shehan Atukorala<shehanatuk@gmail.com>
Merging with upstream master branch
…trimmed to maximum limit; this commit addresses changing the limit var back to 50; Signed-off-by: Shehan Atukorala<shehanatuk@gmail.com>
There was a problem hiding this comment.
Thank you for your contribution 👍
In order to accept your changes please be sure to sure to sign the eclipse contributor agreement (eca) with the same email as your authorship.
I have signed the Eclipse Contributor Agreement now. Let me know if I missed anything. |
JonasHelming
approved these changes
May 17, 2022
There was a problem hiding this comment.
Thank you for your contribution!
I will @vince-fugnitto have a final look and then we can merge this one!
vince-fugnitto
approved these changes
May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
The history of commands typed in the Debug Console in the Debug view(access in the left sidebar of the browser version) was not adhering to the limit specified in the
limitvariable in the file:theia/packages/console/src/browser/console-history.ts.The main issue was that the newly sliced array(
this.values.slice(index)) was not being assigned to the original array.Therefore, I replaced that line with the following:
this.values = this.values.slice(index);in order to resolve this issue.Fixes #10598
How to test
theia/packages/console/src/browser/console-history.tslimitvariable to a lower number such as3yarn build browserthen navigate to/examples/browserand runyarn starthttp://localhost:3000and open theDebugtab in the left sidebarlimitvariable) in the debug console then press the up arrow to validate that the messages saved conforms to the number assigned to thelimitvariable(Ex:limit = 3should cap the maximum number of saved commands up to 3)Review checklist
Reminder for reviewers