Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update node-fetch #10670

Merged
merged 1 commit into from
Jan 27, 2022
Merged

deps: update node-fetch #10670

merged 1 commit into from
Jan 27, 2022

Conversation

vince-fugnitto
Copy link
Member

@vince-fugnitto vince-fugnitto commented Jan 26, 2022

What it does

The pull-request updates node-fetch which previously had a security vulnerability. The fix bumps the dependency to 2.6.7 which includes the fix.

How to test

  1. confirm that yarn download:plugins works correctly and plugins can successfully be downloaded
  2. yarn audit --groups "dependencies" --level=moderate | grep "node-fetch" should not produce any output

Review checklist

Reminder for reviewers

Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com

The commit updates the `node-fetch` dependency which previously had a
`high` security vulnerability (the fix was patched in `2.6.6`).

Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
@vince-fugnitto vince-fugnitto added security issues related to security dependencies pull requests that update a dependency file labels Jan 26, 2022
@JonasHelming JonasHelming self-requested a review January 26, 2022 15:42
Copy link
Contributor

@JonasHelming JonasHelming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well for me, thank you!

@vince-fugnitto vince-fugnitto merged commit 9386179 into master Jan 27, 2022
@vince-fugnitto vince-fugnitto deleted the vf/node-fetch branch January 27, 2022 13:20
@github-actions github-actions bot added this to the 1.22.0 milestone Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies pull requests that update a dependency file security issues related to security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants