Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ascii-only labels for Electron menus #10673

Merged
merged 1 commit into from
Jan 26, 2022

Conversation

colin-grant-work
Copy link
Contributor

What it does

Fixes #10672 by avoiding adding non-ascii arrow characters to 'accelerator' labels in Electron menus.

How to test

  1. On MacOS
  2. Run the Electron application
  3. Open the Selection menu.
  4. See this (with the arrows that Electron uses):

image

  1. Run the Browser application
  2. Open the selection menu
  3. See this (with arrow characters):

image

Review checklist

Reminder for reviewers

@colin-grant-work colin-grant-work added menus issues related to the menu OS/Mac issues related to Mac OS labels Jan 26, 2022
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed that the changes work well 👍

before:

Screen Shot 2022-01-26 at 3 40 48 PM

after:

Screen Shot 2022-01-26 at 3 47 10 PM

I also confirmed there are no regressions, and it also works in the browser.

@colin-grant-work colin-grant-work merged commit 4fa6ec2 into master Jan 26, 2022
@colin-grant-work colin-grant-work deleted the bugfix/ascii-only-accelerators branch January 26, 2022 21:28
@github-actions github-actions bot added this to the 1.22.0 milestone Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
menus issues related to the menu OS/Mac issues related to Mac OS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keyboard shortcuts with arrow keys do not appear in MacOS Electron menus
2 participants