Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace ChangesStream with nano #10764

Merged
merged 1 commit into from
Feb 17, 2022
Merged

Conversation

paul-marechal
Copy link
Member

The former package is no longer maintained and might be vulnerable.

How to test

Not really sure how to test this feature specifically. Help is welcome...

I tried running the new snippet of code in a standalone script and was able to see events coming in.

At the very least applications should still build and start.

Review checklist

Reminder for reviewers

The former package is no longer maintained and might be vulnerable.
@vince-fugnitto vince-fugnitto added dependencies pull requests that update a dependency file security issues related to security labels Feb 17, 2022
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me 👍

  • I did not notice any regressions - the app builds, starts and CI passes

  • There is no longer an audit for debug (previously pulled by changes-stream):

    yarn audit | grep "debug"
    

@paul-marechal paul-marechal merged commit e095076 into master Feb 17, 2022
@paul-marechal paul-marechal deleted the mp/remove-changes-stream branch February 17, 2022 15:59
@github-actions github-actions bot added this to the 1.23.0 milestone Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies pull requests that update a dependency file security issues related to security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants