Implement disabled, isPreferred and documentation fields for code actions

[lucas-koehler]

Fixes #9989
Closes #10073 - this builds on #10073 but also hands in the documentation metadata into monaco.

Contributed on behalf of STMicroelectronics

Signed-off-by: Lucas Koehler lkoehler@eclipsesource.com

What it does

Fixes #9989

• Adds support for the disabled and isPreferred fields to the CodeAction interface
• Adds support for the documentation field to CodeActionProviderMetaData interface.

How to test

• Include my code actions test plugin. For reference, it's code can be found here
• Start the application and open a markdown file
• Type :)
• Lightbulb should be blue to indicate a preferred fix
• Open quick fix menu and look at the entries
  • The poop emoji entry is hidden (present on master).
  • There should be an entry Learn more about Emojis... which opens the emoji wikipedia page when selected. This is the documentation entry

Review checklist

• As an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• As a reviewer, I agree to behave in accordance with the review guidelines

[vince-fugnitto]

I confirmed that functionally the changes work very well 👍

• confirmed that disabled items are in fact disabled compared to master
• confirmed that documentation entries work well

[vince-fugnitto]

@lucas-koehler I believe that value is non-optional in vscode, should we align?

• vscode@master
• vscode@1.53.2

[lucas-koehler]

@vince-fugnitto Thanks for your review :) I aligned CodeActionKind's value property to be non-optional and removed the now obsolete ! operators.

[msujew]

The changes are looking good to me!

• Preferred code actions are highlighted
• Clicking the documentation code actions brings up the pages in the browser

I noticed that a separator is missing in Theia compared to VSCode:

Theia:

I assume that's unrelated to your changes. Or do you think you can "simply" add that as well?

[lucas-koehler]

I noticed that a separator is missing in Theia compared to VSCode:
[...]
I assume that's unrelated to your changes. Or do you think you can "simply" add that as well?

@msujew Unfortunately, as this menu comes from monaco, I do not know how to add this in a simple way.

[msujew]

@lucas-koehler Completely fine with me. Since Colin is working on updating Monaco anyway, it's not that important 👍

[JonasHelming]

@vince-fugnitto : Fine with merging this?