Add missing property to CustomDocumentOpenContext #10784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
planger
force-pushed
the
planger/issues/10005
branch
from
bebe882
to
fde9b0f
Compare
VSCode defines the optional property `untitledDocumentData` in `CustomDocumentOpenContext`. In theia.d.ts, this property is however missing. As it is optional and is not used from the main implementation, this change is merely achieving source compatibility, but prepares its usage in the ext implementation of the plugin API. Contributed on behalf of STMicroelectronics Signed-off-by: Philip Langer <planger@eclipsesource.com> Fixes eclipse-theia#10005 Change-Id: I1b4d67b5b11fa2c94a8590aac6b8ad0f040cee94
planger
force-pushed
the
planger/issues/10005
branch
from
fde9b0f
to
437d657
Compare
msujew
approved these changes
Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
VSCode defines the optional property
untitledDocumentDatainCustomDocumentOpenContext. Intheia.d.ts, this property is however missing. As it is optional and is not used from the plugin main implementation, this change is merely achieving source compatibility, but prepares its usage in the ext implementation of the plugin API.Fixes #10005
Contributed on behalf of STMicroelectronics
How to test
As this change doesn't introduce new functionality per se, we just need to make sure existing functionality, especially with respect to custom editors contributed by VS Code extensions still work. Therefore, I tested with
cat-customs.cat-customsandvscode.simple-browser, which both seem to be still working fine.Review checklist
Reminder for reviewers