Preferences UI: Delegate Classnames to Type Renderers

[colin-grant-work]

What it does

The Monaco uplift exposed a bug in the preference node renderer system in which the base renderer was applying type-specific classnames. Since renderers are already selected on the basis of type, the application of type-specific classes has been delegated to the individual renderers.

How to test

1. Open the Preferences UI
2. Search for editor.semanticHighlighting.enabled.
3. Observe that it is correctly rendered as a select input.
4. Check other preference nodes, especially booleans (checkmarks)
5. Observe that they are all rendered correctly.

Review checklist

• As an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• As a reviewer, I agree to behave in accordance with the review guidelines

[vince-fugnitto]

The changes look good to me, I confirmed that the issue is fixed 👍

master:

pr: