Check application state before showing file resource dialog #10900
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #9843 by checking application state before trying to show a file-resource-related dialog.
I think ideally, it wouldn't be the resource that was responsible for this dialog: different contexts should be allowed to handle it differently. But this fix does address the specific problem described in the bug with a minimum change in the architecture. I'm open to other suggestions (for example, maybe if we're running remotely, we should automatically reject rather than automatically approve the request?).
How to test
Review checklist
Reminder for reviewers