plugin: add support for title property in InputBoxOptions
#10920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vince-fugnitto
added
monaco
vince-fugnitto
commented
Mar 24, 2022
vince-fugnitto
force-pushed
the
vf/monaco-title
branch
from
08bb7cc
to
9dc90e9
Compare
The commit adds support for the `title` property in `InputBoxOptions` which allows users to specify a title for their quick-input menus. The change also aligns the styling of the quick-input to use the proper input background used across the application, and for the `title`. Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto
force-pushed
the
vf/monaco-title
branch
from
9dc90e9
to
7fccdc4
Compare
|
@msujew it turns out that the color is contributed by monaco so we do not need to register it ourselves, but instead can directly use it. As part of the steps to test the pull-request I created a theme that sets a specific color to the title-pr.mp4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes: #10030.
The pull-request adds support for the
titleproperty inInputBoxOptionswhich is used to give a title to quick-input menus.The change also includes styling updates to the quick-input to give the input the same styling as the rest of the application's input fields, and also sets the
titlebackground similarly to VS Code.title-pr.mp4
How to test
hello worldcommandtitlepropertytest-themeReview checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com