Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[playwright] Start theia with THEIA_CONFIG_DIR #10925

Merged
merged 1 commit into from
Mar 30, 2022
Merged

[playwright] Start theia with THEIA_CONFIG_DIR #10925

merged 1 commit into from
Mar 30, 2022

Conversation

planger
Copy link
Contributor

@planger planger commented Mar 25, 2022

What it does

This change modifies the scripts so that theia as a system under test is started with a dedicated temporary THEIA_CONFIG_DIR for running the playwright tests.

Fixes #10800

How to test

  1. Check your local .theia folder
  2. Run yarn test:playwright
  3. Observe how this doesn't affect your local .theia folder
  4. Observe how instead examples/playwright/.tmp.cfg is used instead

Review checklist

Reminder for reviewers

@planger
[playwright] Start theia with THEIA_CONFIG_DIR
d274a33 
This change modifies the scripts so that theia as a system under test is
started with a dedicated temporary THEIA_CONFIG_DIR for running the
playwright tests.

Fixes eclipse-theia#10800

Change-Id: I27b3ee6d908101f7c619a42d7c552a4bf07ca9ac
@vince-fugnitto vince-fugnitto added the playwright issues related to playwright tests label Mar 25, 2022
colin-grant-work
colin-grant-work approved these changes Mar 25, 2022
View reviewed changes
Copy link
Contributor

@colin-grant-work colin-grant-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm that with these changes, default config directory is no longer affected by Playwright.

@JonasHelming JonasHelming merged commit ed8aa41 into eclipse-theia:master Mar 30, 2022
@JonasHelming JonasHelming added this to the 1.24.0 milestone Mar 30, 2022
@planger planger deleted the issues/10800 branch March 30, 2022 07:24
@planger planger mentioned this pull request Mar 30, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin-grant-work colin-grant-work colin-grant-work approved these changes

Assignees
No one assigned
Labels
playwright issues related to playwright tests
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.

Playwright tests affect user's config
4 participants
@planger @colin-grant-work @JonasHelming @vince-fugnitto