Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sash visibility based on check of all ViewContainerParts #10941

Conversation

colin-grant-work
Copy link
Contributor

@colin-grant-work colin-grant-work commented Mar 28, 2022

What it does

Fixes #10894 by updating sash visibility for all ViewContainerParts when any ViewContainerPart is collapsed or uncollapsed or changes visibility.

How to test

  1. In a view container with many parts (e.g. SCM with GitLens installed)
  2. Confirm that sashes are visible and can be used to resize parts if you are below the top of the first uncollapsed widget and above the bottom of the last uncollapsed widget.
  3. Confirm that sashes are invisible otherwise.

Review checklist

Reminder for reviewers

@colin-grant-work colin-grant-work added shell issues related to the core shell ui/ux issues related to user interface / user experience labels Mar 28, 2022
@kaiyue0329
Copy link
Contributor

The changes look great 👍 ! I was able to see

  • No sash when all ViewContainerParts are all collapsed
  • No sash when there is only one uncollapsed ViewContainerPart in the left panel
  • Sashes for all the ViewContainerParts between the firstUncollapsed and the lastUncollapsed

@vince-fugnitto vince-fugnitto self-requested a review March 30, 2022 19:17
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed the bug on master and that the pull-request resolves the issue 👍
I did not notice any regressions, and the code also looks good to me.

@colin-grant-work colin-grant-work merged commit f89e826 into eclipse-theia:master Mar 31, 2022
@colin-grant-work colin-grant-work added this to the 1.24.0 milestone Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
shell issues related to the core shell ui/ux issues related to user interface / user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't resize view container parts when many present
3 participants