Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use correct colors for problem markers #10950

Merged
merged 1 commit into from
Mar 30, 2022
Merged

Use correct colors for problem markers #10950

merged 1 commit into from
Mar 30, 2022

Conversation

msujew
Copy link
Member

@msujew msujew commented Mar 29, 2022

What it does

Closes #10949

How to test

  1. Edit a file in your workspace so that it shows errors/warnings
  2. Assert that the file node color in the navigator matches VSCode's color

Review checklist

Reminder for reviewers

@msujew msujew added ui/ux issues related to user interface / user experience markers issues related to problem markers labels Mar 29, 2022
vince-fugnitto
vince-fugnitto approved these changes Mar 29, 2022
View reviewed changes
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm that the theming color looks good 👍

@msujew msujew merged commit 61cbbd3 into master Mar 30, 2022
@msujew msujew deleted the msujew/update-decoration-colors branch March 30, 2022 13:28
@github-actions github-actions bot added this to the 1.24.0 milestone Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vince-fugnitto vince-fugnitto vince-fugnitto approved these changes

Assignees
No one assigned
Labels
markers issues related to problem markers ui/ux issues related to user interface / user experience
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.

Color mismatch for error/warning markers on files
2 participants
@msujew @vince-fugnitto