Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode: support generic CodeActionProvider #10988

Merged
merged 1 commit into from
Apr 6, 2022

Conversation

vince-fugnitto
Copy link
Member

What it does

The pull-request updates CodeActionProvider to accept the generic CodeAction type.
The change ultimately aligns the API with VS Code and will be marked as supported in the compatibility report.

How to test

  1. include the following test extension code-actions-sample-0.0.2.zip
  2. start the application
  3. open a markdown file
  4. type :)
  5. a code-action menu should appear where the entries should work
code-actions.mp4

Review checklist

Reminder for reviewers

Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com

The commit adjusts `CodeActionProvider` to accept the generic
`CodeAction` type, and ultimately mark the compatibility report as
supported.

Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
@vince-fugnitto vince-fugnitto added the vscode issues related to VSCode compatibility label Apr 4, 2022
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

  • The API now aligns correctly with vscode.d.ts
  • Code actions provider continue to work as expected

@vince-fugnitto vince-fugnitto merged commit 1c7bdf7 into master Apr 6, 2022
@vince-fugnitto vince-fugnitto deleted the vf/code-action-provider branch April 6, 2022 14:53
@github-actions github-actions bot added this to the 1.25.0 milestone Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants