Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dep: resolve moment vulnerability #11009

Merged
merged 1 commit into from
Apr 11, 2022
Merged

dep: resolve moment vulnerability #11009

merged 1 commit into from
Apr 11, 2022

Conversation

vince-fugnitto
Copy link
Member

What it does

The pull-request resolves a known vulnerability with moment, by updating the dependency to the patched version 2.29.2.
Downstream extensions can add a resolution for the time being.

How to test

There should not be a change in functionality, CI should be green (build, and tests).

Review checklist

Reminder for reviewers

Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com

The commit updates the `moment` dependency to a version which fixes the
known security vulnerability.

Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
@vince-fugnitto vince-fugnitto added security issues related to security dependencies pull requests that update a dependency file labels Apr 11, 2022
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The CI pipeline is green and the application builds and runs as expected 👍

@vince-fugnitto vince-fugnitto merged commit 1819ebf into master Apr 11, 2022
@vince-fugnitto vince-fugnitto deleted the vf/moment branch April 11, 2022 17:40
@github-actions github-actions bot added this to the 1.25.0 milestone Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies pull requests that update a dependency file security issues related to security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants