Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix more quick input styling issues #11029

Merged
merged 2 commits into from
Apr 15, 2022
Merged

Fix more quick input styling issues #11029

merged 2 commits into from
Apr 15, 2022

Conversation

msujew
Copy link
Member

@msujew msujew commented Apr 14, 2022

What it does

  1. Closes monaco: quick-input list styling needs to be adjusted #10987 by fixing the actual source of the misalignment. A codicon css rule sets the line-height of the whole row to 13px which messes up all of the sub-layouting
  2. Fixes a minor font issue for label-description parts of the quick input row, which used a serif font. See also monaco: fix styling of toggled commands #10962

How to test

  1. Open the command palette and enter view: toggle
  2. Assert that quick input items with checkmarks are correctly layouted
  3. Run the Open Recent Workspaces command (The original issue only seems to appear on Windows+Electron, don't know why)
  4. Assert that the label-description font is using the default app font

Review checklist

Reminder for reviewers

@msujew msujew added ui/ux issues related to user interface / user experience quick-open issues related to the quick-open labels Apr 14, 2022
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking a look into fixing the problem 👍
I confirmed that it works well for, I also confirmed using different file-icon themes.

@msujew msujew merged commit c8e046f into master Apr 15, 2022
@msujew msujew deleted the msujew/quick-input-styling branch April 15, 2022 12:18
@github-actions github-actions bot added this to the 1.25.0 milestone Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quick-open issues related to the quick-open ui/ux issues related to user interface / user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

monaco: quick-input list styling needs to be adjusted
2 participants