Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coerce extension localizations into expected format #11039

Merged
merged 1 commit into from
Apr 20, 2022
Merged

Coerce extension localizations into expected format #11039

merged 1 commit into from
Apr 20, 2022

Conversation

msujew
Copy link
Member

@msujew msujew commented Apr 18, 2022 •
edited

What it does

Closes #11038

Some localization values inside of the package.nls.json file aren't in a string but LocalizeInfo { message: string, comment: string } format. This change simply extracts the message property in case the value is of type LocalizeInfo.

How to test

  1. Repeat reproduction steps from Preference Markdown renderer fails for complex localizations #11038
  2. The preferences should be rendered correctly

Review checklist

Reminder for reviewers

@msujew msujew added vscode issues related to VSCode compatibility localization issues related to localization/internalization/nls labels Apr 18, 2022
colin-grant-work
colin-grant-work approved these changes Apr 20, 2022
View reviewed changes
Copy link
Contributor

@colin-grant-work colin-grant-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, and resolves the problems with unexpected types in preference schemata. 👍

@msujew msujew merged commit b5a3cd4 into master Apr 20, 2022
@msujew msujew deleted the msujew/localize-info-extensions branch April 20, 2022 20:12
@github-actions github-actions bot added this to the 1.25.0 milestone Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin-grant-work colin-grant-work colin-grant-work approved these changes

Assignees
No one assigned
Labels
localization issues related to localization/internalization/nls vscode issues related to VSCode compatibility
Projects
None yet
Milestone
1.25.0
Development

Successfully merging this pull request may close these issues.

Preference Markdown renderer fails for complex localizations
2 participants
@msujew @colin-grant-work