Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow easier extensibility for custom Theia applications #11071

Merged
merged 1 commit into from
Apr 27, 2022
Merged

Allow easier extensibility for custom Theia applications #11071

merged 1 commit into from
Apr 27, 2022

Conversation

martin-fleck-at
Copy link
Contributor

What it does

Fixes #11070 by allowing easier customization of the TheiaApp object.

How to test

A new Playwright test was added to cover the new functionality. Old functionality is covered by existing tests.

Review checklist

Reminder for reviewers

@vince-fugnitto vince-fugnitto added the playwright issues related to playwright tests label Apr 26, 2022
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, CI is green, and I also confirmed that the playwright tests pass on macOS.

@JonasHelming JonasHelming merged commit 7f5047f into eclipse-theia:master Apr 27, 2022
@JonasHelming JonasHelming modified the milestones: v1.25.0, 1.25.0 Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
playwright issues related to playwright tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Playwright: Allow easier extensibility for custom Theia applications
3 participants