Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MacOS browser menu keybinding display #11092

Merged
merged 1 commit into from
May 2, 2022
Merged

Fix MacOS browser menu keybinding display #11092

merged 1 commit into from
May 2, 2022

Conversation

colin-grant-work
Copy link
Contributor

@colin-grant-work colin-grant-work commented Apr 29, 2022 •
edited

What it does

Fixes #10931
On master, keybindings do not display correctly in menus in MacOS in the browser. This PR fixes that by ensuring that Phosphor receives ascii-only keybinding descriptions, which it then converts into the expected MacOS characers.

How to test

  1. On MacOS.
  2. Start the browser application
  3. Open the File menu.
  4. You should see correctly rendered keyboard shortcuts.
  5. Open the keybindings widget.
  6. You should still see MacOS style characters in that widget.

image

Review checklist

Reminder for reviewers

@colin-grant-work colin-grant-work added OS/Mac issues related to Mac OS menus issues related to the menu labels Apr 29, 2022
@colin-grant-work colin-grant-work force-pushed the bugfix/macos-browser-menu-keybindings branch from dfcd547 to 61ad9fc Compare April 29, 2022 14:26
vince-fugnitto
vince-fugnitto approved these changes Apr 29, 2022
View reviewed changes
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me 👍

I confirm that:

  • macos the menu keyboard shortcuts are now properly rendered
  • macos the keyboard shortcuts view displays the rendered keybindings
  • no regressions on linux

@colin-grant-work colin-grant-work merged commit 08722fa into eclipse-theia:master May 2, 2022
@colin-grant-work colin-grant-work deleted the bugfix/macos-browser-menu-keybindings branch May 2, 2022 14:29
@colin-grant-work colin-grant-work added this to the 1.26.0 milestone May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vince-fugnitto vince-fugnitto vince-fugnitto approved these changes

Assignees
No one assigned
Labels
menus issues related to the menu OS/Mac issues related to Mac OS
Projects
None yet
Milestone
1.26.0
Development

Successfully merging this pull request may close these issues.

Sidebar Cog Menu Shows Bad Keyboard Shortcuts
2 participants
@colin-grant-work @vince-fugnitto