Prevent MonacoEditorService from instantiating ContextKeyService thro… #11095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vince-fugnitto
approved these changes
May 2, 2022
There was a problem hiding this comment.
I confirm that the changes work as expected, we can now handle setContext calls properly from plugins in order to support custom clause contexts. I also confirmed that existing when clauses work as expected causing no regressions.
colin-grant-work
force-pushed
the
bugfix/monaco-context-key-service
branch
from
cb8b05f
to
7b09850
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes: #11096.
If we wish to override Monaco services, we must do so before the same services are instantiated by Monaco by other means. At the moment, one of our desired overrides, the
MonacoEditorServiceis instantiating aContextKeyServiceusing Monaco methods, but we want to override theContextKeyServiceas well. This PR changes the way theMonacoEditorServiceaccesses theContextKeyServiceto allow the override to take effect.How to test
Enablement: EnableandEnablement: Disablecommands.Show Enablement Issuewidget appears and disappears from its view container. (But due to viewsContainers should be hidden when empty #10778 , the view container will not close)Review checklist
Reminder for reviewers