Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update keybinding widget when keybindings change #11102

Conversation

colin-grant-work
Copy link
Contributor

What it does

In the review of #8776, it was noticed that the keybinding widget does not update in response to changes to keybindings, so that at startup, it can get stuck displaying default values before user or workspace values are processed.

How to test

  1. Modify a keybinding.
  2. With the keybinding widget open, restart the application.
  3. Find the modified keybinding.
  4. Observe that modified keybinding is shown rather than the default.

Review checklist

Reminder for reviewers

@colin-grant-work colin-grant-work added the keybindings issues related to keybindings label May 3, 2022
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed that the changes work as expected 👍

  • updated keybindings are properly reflected on reload
  • the query is restored on reload, the view correctly restores the state and re-searches

@colin-grant-work colin-grant-work merged commit 1ac9da1 into eclipse-theia:master May 4, 2022
@colin-grant-work colin-grant-work deleted the bugfix/update-keyboard-widget-on-change branch May 4, 2022 23:09
@colin-grant-work colin-grant-work added this to the 1.26.0 milestone May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keybindings issues related to keybindings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants