Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Imports from
index.ts
files in the same directory as a file or a higher level almost always entail circular dependencies. That doesn't have to be a catastrophe, but it's not a good idea. This PR adds a lint rule forbidding such imports and fixes those cases that currently exist. This reduces the number of warnings fromwebpack
from 95 to 81.How to test
from '.'
orfrom '..'
in our code.Review checklist
Reminder for reviewers