Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repo: remove low-hanging deprecations #11185

Merged
merged 1 commit into from
Jun 13, 2022

Conversation

vince-fugnitto
Copy link
Member

What it does

The pull-request includes multiple commits addressing the removal of deprecations present in the framework.
The methods, interfaces, constants and re-exports were deprecated for some time, and a cleanup was in order.

How to test

Confirm that CI passes (both builds and tests).

Review checklist

Reminder for reviewers

Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com

@vince-fugnitto vince-fugnitto added the quality issues related to code and application quality label May 20, 2022
Copy link
Contributor

@colin-grant-work colin-grant-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks to be in order to me. Only one comment.

Copy link
Contributor

@colin-grant-work colin-grant-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. The code is cleaner, the tests pass, and the changelog entry appears comprehensive.

@vince-fugnitto
Copy link
Member Author

I'll merge tomorrow if there are no objections.

@vince-fugnitto vince-fugnitto merged commit b3adc5a into master Jun 13, 2022
@vince-fugnitto vince-fugnitto deleted the vf/low-hanging-deprecations branch June 13, 2022 11:44
@github-actions github-actions bot added this to the 1.27.0 milestone Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quality issues related to code and application quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants