Move WebviewViewResolveContext to root namespace #11216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #11149 ? |
|
Yes 👍 Added it the PR description |
msujew
approved these changes
Jun 1, 2022
sgraband
force-pushed
the
sgr/movenamespace
branch
from
0ee38e4
to
1fa8f77
Compare
The WebviewViewResolveContext was previously in the window namespace. Removed it in the window namespace and added it to root namespace. Fixes eclipse-theia#11149. Contributed on behalf of STMicroelectronics.
sgraband
force-pushed
the
sgr/movenamespace
branch
from
1fa8f77
to
ff3597a
Compare
|
I rebased and squashed the commits. Can this be merged? |
|
@sgraband I'll merge this a bit later, when the CI run has finished successfully 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
To be compatable with the VSCode API the
WebviewViewResolveContextneeds to be in the root namespace. See here.The WebviewViewResolveContext was previously in the window namespace.
Removed it from the window namespace and added it to root namespace.
Fixes #11149.
Contributed on behalf of STMicroelectronics.
How to test
Review checklist
Reminder for reviewers