Fix runtime-import-check errors
#11224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vince-fugnitto
added
quality
alvsan09
force-pushed
the
asl/enable-runtime-import-checks
branch
from
0825101
to
fe85409
Compare
vince-fugnitto
approved these changes
May 31, 2022
There was a problem hiding this comment.
The changes look good to me 👍
I confirmed that:
- renaming
DebugPluginConfigurationtoPluginDebugConfigurationmakes sense - moving
PluginDebugConfigurationtoplugin-devoverdebugis better since it is plugin-specific - hosted-plugin debugging works (aside from known issue Debugger will not break when debugging VS Code extensions via
Hosted Plugin: Debug Instance#7652) - custom-editors work well (using cat example)
Signed-off-by: Alvaro Sanchez-Leon <alvaro.sanchez-leon@ericsson.com>
Signed-off-by: Alvaro Sanchez-Leon <alvaro.sanchez-leon@ericsson.com>
alvsan09
force-pushed
the
asl/enable-runtime-import-checks
branch
from
fe85409
to
610fbf1
Compare
Thanks for the review @vince-fugnitto! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes
runtime-import-checkerrors related toplugin-api-rpcas well as from the re-use of
DebugPluginConfiguration.This is done by moving relevant code under their proper runtime (browser vs common vs node).
For more details see: #10418
How to test
There should not be a change in functionality:
Review checklist
Reminder for reviewers