Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preference: fix preference sections #11306

Merged
merged 1 commit into from
Jun 20, 2022
Merged

Conversation

vince-fugnitto
Copy link
Member

What it does

The commit adds toolbar preferences to their proper section and not under Extensions (related to plugins). The toolbar preferences are now under Features.

image

How to test

  1. open the preferences-view.
  2. confirm that under Features there are the Toolbar preferences.

Review checklist

Reminder for reviewers

Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com

@vince-fugnitto vince-fugnitto added preferences issues related to preferences toolbar issues related to the toolbar labels Jun 16, 2022
@vince-fugnitto vince-fugnitto self-assigned this Jun 16, 2022
Copy link
Contributor

@colin-grant-work colin-grant-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the right place to me. 👍

@vince-fugnitto vince-fugnitto changed the title preference: add toolbar to proper section preference: fix preference sections Jun 16, 2022
The commit adds `toolbar` preferences to their proper section and not
under `Extensions` (related to plugins). The `toolbar` preferences are
now under `Features`. It also fixes the same for `notification` and
`scm`

Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
Copy link
Contributor

@colin-grant-work colin-grant-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These more extensive changes also look good to me. 👍

@vince-fugnitto vince-fugnitto merged commit fd85035 into master Jun 20, 2022
@vince-fugnitto vince-fugnitto deleted the vf/toolbar-preference branch June 20, 2022 15:18
@github-actions github-actions bot added this to the 1.27.0 milestone Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preferences issues related to preferences toolbar issues related to the toolbar
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants