Preserve recent commands for different locales

[msujew]

What it does

Closes #11335

Makes the internal list of recently used commands a simple string array containing the IDs of these commands. This allows us to have them independent from the selected locale.

How to test

1. Run the Configure Display Language command
2. Select another locale
3. Open the command palette, the Configure Display Language command should still be in the list of recently used commands.

Review checklist

• As an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• As a reviewer, I agree to behave in accordance with the review guidelines

[colin-grant-work]

This worked for me, but with the caveat that the first time I ran it, I wound up with duplicates of several of my recent commands:

Note that Color Theme and Configure Display Language each appear twice.

[colin-grant-work]

👍

[msujew]

@colin-grant-work I couldn't reproduce the issue, but I'm using an intermediate Set now to avoid duplicates. Does that fix the issue?

[colin-grant-work]

Is working, and is now more robust against duplicates that have snuck into the state restoration system on application close.

[colin-grant-work]

I think we should really not use Command.equals anywhere. The only source of truth about command identity is the id field, so checking anything else, for example here,

theia/packages/core/src/browser/quick-input/quick-command-service.ts

Lines 198 to 209 in 4061027

	if (limit > 0) {
	rCommands.push(...recentCommands.filter(r =>
	!this.exemptedCommands.some(c => Command.equals(r, c)) &&
	allCommands.some(c => Command.equals(r, c)))
	);
	if (rCommands.length > limit) {
	rCommands = rCommands.slice(0, limit);
	}
	}
	// Build the list of other commands.
	const oCommands = allCommands.filter(c => !rCommands.some(r => Command.equals(r, c)));

is just misleading: it can only return false negatives and introduce duplicates.