Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nls: localize no-Info messages #11354

Merged
merged 1 commit into from
Jun 28, 2022
Merged

nls: localize no-Info messages #11354

merged 1 commit into from
Jun 28, 2022

Conversation

vince-fugnitto
Copy link
Member

What it does

The commit sets up the localizations for no-Info messages which are used by views when they do not provide any content but instead display a default message. Previously the label was hardcoded and not set up for localization.

How to test

The code sets up localization which should work when we switch languages after we run a translation of our code-base (#10885).

  1. start the application
  2. switch language using configure display language
  3. confirm that the three views are not localized but should be after Regular translation update #10885.

Review checklist

Reminder for reviewers

Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com

The commit sets up the localizations for `no-Info` messages which are
used by views when they do not provide any content but instead display a
default message. Previously the label was hardcoded and not set up for
localization.

Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
@vince-fugnitto vince-fugnitto added the localization issues related to localization/internalization/nls label Jun 28, 2022
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@vince-fugnitto vince-fugnitto merged commit 248911c into master Jun 28, 2022
@vince-fugnitto vince-fugnitto deleted the vf/localize-no-info branch June 28, 2022 15:41
@github-actions github-actions bot added this to the 1.27.0 milestone Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
localization issues related to localization/internalization/nls
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants