Use same replacement text for entire replacement cycle #11374
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
In our current code for
Replace All
actions in the SiW widget, the code isasync
but refers tothis._replaceTerm
, which can be updated by user actions while the replacement is running, resulting in different values being inserted in different editors. This PR caches the value present at the start of the operation and uses it in everywhere where reference to it is required.How to test
master
, later editors might get the new value, depending on number of results and speed of file actions)Review checklist
Reminder for reviewers