New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stub vscode 'Tests' API #11717
Stub vscode 'Tests' API #11717
Conversation
ab3905b
to
45cc1ff
Compare
Relates to #10669 |
45cc1ff
to
a6304c3
Compare
@alvsan09 Is this ready for a re review? |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implementations appear sound for stubs (where applicable) and the plugins activate successfully, and the API is correctly evaluated as either newly supported or newly stubbed by the comparator.
@alvsan09 Let's merge this if possible :-) |
This enables the possibility to load and start plugins which depend on the 'Tests' API. The 'Tests' functionality will not be operational but the rest of the functionality offered by the plugin will be. Signed-off-by: Alvaro Sanchez-Leon <alvaro.sanchez-leon@ericsson.com>
8fdcbe2
to
d1451f2
Compare
The commits were squashed and then re-based to latest master just before merging. |
@colin-grant-work , thanks for the review and testing !! |
|
What it does
This enables the possibility to load and start plugins which depend on the 'Tests' API.
The 'Tests' functionality will not be operational but the rest of
the functionality offered by the plugin will be.
How to test
vscode
API version intheia
to1.68.0
, at:theia
instance before switching to this PR, by installing the followingvscode
sample: https://github.com/alvsan09/vscode-extension-samples/releases/download/test-provider-prel-0.0.1/test-provider-sample-0.0.1.vsixmarkdown
files (extension.md
)theia
repository to use this PRA more realistic test can be achieved using the latest
ms-python.python
extension, version2022.14.0.
,however additional API support is needed in addition to this change.
A test branch is provided for this purpose:
theia
repository to load this PR on top of the branch offering additional missing API as follows:Download the latest python extension via
openVSX
registry:https://open-vsx.org/api/ms-python/python/2022.14.0/file/ms-python.python-2022.14.0.vsix
Using the extensions view install the
vsix
aboveThe extension will attempt to install 4 python related extensions, the ones related to
jupyter
notes will not be successful however the corepython
extension will install and be functional, see the following video clip.tests_api_stub.mp4
The stubbed API has been marked in
theia.d.ts
with the special tag@stubbed
in order to reflect it is as such in the report generated by theeclipse-theia/vscode-theia-comparator
See a portion of the generated report when running it locally:
Review checklist
Reminder for reviewers