Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: add confirmation prompt when executing clear command history #12510

Merged

Conversation

helloworldmygithub
Copy link
Contributor

@helloworldmygithub helloworldmygithub commented May 10, 2023

What it does

Closes: #12495.

The pull-request adds a confirmation prompt when executing clear command history.

How to test

clear_command_history

Review checklist

Reminder for reviewers

The commit add confirmation prompt when executing clear command history

Signed-off-by: zhangyi <1401457589@qq.com>
@vince-fugnitto vince-fugnitto added core issues related to the core of the application ui/ux issues related to user interface / user experience labels May 10, 2023
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thank you for your first contribution!

@helloworldmygithub
Copy link
Contributor Author

Okay, may I ask if it will be merged? Do I need to do anything else?

@vince-fugnitto vince-fugnitto merged commit b04bac3 into eclipse-theia:master May 11, 2023
9 checks passed
@vince-fugnitto vince-fugnitto added this to the 1.38.0 milestone May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core issues related to the core of the application ui/ux issues related to user interface / user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

core: add confirmation prompt when executing clear command history
2 participants