Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for WebviewPanelSerializer not working in Theia #12854

Merged
merged 4 commits into from
Aug 24, 2023

Conversation

vatsal-uppal-1997
Copy link
Contributor

What it does

Fixes #12834

For a detailed root cause analysis, refer to this comment

How to test

  1. Clone the test repository from issue WebviewPanelSerializer not working in Theia #12834
  2. cd into the "myext" folder and create a packaged vscode plugin by running the "vsce package" command
  3. Copy the packaged vsix file into this issue's git repository and paste it into the "plugins" folder
  4. Run the application and see if you're able to reproduce issue WebviewPanelSerializer not working in Theia #12834

Review checklist

Reminder for reviewers

Copy link
Contributor

@jfaltermeier jfaltermeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks you, lgtm. I've tested with the reproducer on the ticket and it is working for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vscode issues related to VSCode compatibility webviews issues related to webviews
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

WebviewPanelSerializer not working in Theia
3 participants