Add support for multiline searches #12868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vince-fugnitto
added
the
search in workspace
Signed-off-by: Christian Radke <c.radke@posteo.de>
Signed-off-by: Christian Radke <c.radke@posteo.de>
Signed-off-by: Christian Radke <c.radke@posteo.de>
KR155E
force-pushed
the
multiline-searches
branch
from
62345db
to
d2646eb
Compare
Signed-off-by: Christian Radke <c.radke@posteo.de>
|
Thanks for the feedback! Please pull again, I have pushed a fix for the issue. |
kittaakos
reviewed
Aug 31, 2023
packages/search-in-workspace/src/browser/components/search-in-workspace-textarea.tsx
Outdated
Show resolved
Hide resolved
msujew
reviewed
Sep 11, 2023
|
Well spotted, thanks! Had to do with the move to react-autosize-textarea. I have updated the CSS to fix the regression. |
msujew
reviewed
Sep 12, 2023
packages/search-in-workspace/src/browser/search-in-workspace-result-tree-widget.tsx
Outdated
Show resolved
Hide resolved
packages/search-in-workspace/src/browser/search-in-workspace-result-tree-widget.tsx
Outdated
Show resolved
Hide resolved
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #11656
How to test
Open the same folder in both Theia and VSCode, search for the same multiline string and compare.
Review checklist
Reminder for reviewers