Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keybinding: Error Message Localization #12889

Merged

Conversation

FernandoAscencio
Copy link
Contributor

What it does

Closes #12878

How to test

Same steps as in #12878

Review checklist

Reminder for reviewers

Closes eclipse-theia#12878

Signed-Off-By: FernandoAscencio <fernando.ascencio.cama@ericsson.com>
@vince-fugnitto vince-fugnitto added the localization issues related to localization/internalization/nls label Sep 1, 2023
packages/core/src/common/keys.ts Outdated Show resolved Hide resolved
packages/core/src/common/keys.ts Outdated Show resolved Hide resolved
packages/core/src/common/keys.ts Outdated Show resolved Hide resolved
FernandoAscencio and others added 3 commits September 1, 2023 14:32
Co-authored-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
Co-authored-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
Co-authored-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
@FernandoAscencio
Copy link
Contributor Author

@vince-fugnitto
Makes sense. The changes have been comited.

Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@msujew msujew merged commit d2b7f3b into eclipse-theia:master Sep 25, 2023
14 checks passed
@vince-fugnitto vince-fugnitto added this to the 1.42.0 milestone Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
localization issues related to localization/internalization/nls
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Information label "unrecognized key" is not localized in HotKey Binding
3 participants