Add support for provideDocumentRangesFormattingEdits. #13020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…heia#12939 Contributed on behalf of STMicroelectronics Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
martin-fleck-at
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Adds the optional function
Support DocumentRangeFormattingEditProvider.provideDocumentRangesFormattingEdits(...)to the VS Code API. Since our current version of the Monaco editor does not support this function yet, the change is entirely non-functional. We'll have to provide an implementation once we've uplifted the Monaco implementation.Fixes #12939
How to test
There is nothing to test, really. In order to make sure nothing is broken, I selected a range in a json file and invoked "Format Selection", which worked fine.
Contributed on behalf of STMicroelectronics
Follow-ups
Review checklist
Reminder for reviewers