Set electron dialogs to modal by default

[zole40]

What it does

I found regression in related to the electron dialogs #13042

How to test

1. Build the electron example
2. Run electron example
3. Go to the file menu and click on the open folder

Follow-ups

Review checklist

• As an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• As a reviewer, I agree to behave in accordance with the review guidelines

[AlexandraBuzila]

Hi @zole40! Thank you for the fix, it works as expected 👍

However, I think it would be better if the modal prop was already initialized in the toOpenDialogOptions and toSaveDialogOptions from the ElectronFileDialogService, together with the other dialog options.

[zole40]

Hi @zole40! Thank you for the fix, it works as expected 👍

However, I think it would be better if the modal prop was already initialized in the toOpenDialogOptions and toSaveDialogOptions from the ElectronFileDialogService, together with the other dialog options.

Should we set a default value if it is undefined?
For example: result.modal = props.modal ?? true;

[AlexandraBuzila]

Should we set a default value if it is undefined? For example: result.modal = props.modal ?? true;

Yes, exactly. That would ensure that the options already have the default value for the modal prop when it is checked in electron-api-main.ts

[AlexandraBuzila]

Thank you, it looks good to me!

@JonasHelming could you have a look as well, please?