Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix render toolbar error when group is undefined #13124

Merged
merged 1 commit into from Nov 30, 2023
Merged

fix: fix render toolbar error when group is undefined #13124

merged 1 commit into from Nov 30, 2023

Conversation

huzhixiao
Copy link
Contributor

@huzhixiao huzhixiao commented Nov 30, 2023 •
edited

What it does

fix render toolbar error when group is undefined
image

How to test

use @theia/toolbar

Follow-ups

Review checklist

Reminder for reviewers

@huzhixiao huzhixiao changed the title fix: fix render error when group is undefined fix: fix render toolbar error when group is undefined Nov 30, 2023
msujew
msujew approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me 👍

@msujew msujew merged commit fa52032 into eclipse-theia:master Nov 30, 2023
13 of 14 checks passed
@vince-fugnitto vince-fugnitto added this to the 1.44.0 milestone Nov 30, 2023
@huzhixiao huzhixiao deleted the patch-2 branch December 1, 2023 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msujew msujew msujew approved these changes

Assignees
No one assigned
Labels
None yet
Projects
PR Backlog
Archived in project
Milestone
1.44.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@huzhixiao @msujew @vince-fugnitto