fix: debug configuration provider replaces different provider #13196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: arekzaluski <arkadiusz.zaluski@arm.com>
arekzaluski
commented
Dec 20, 2023
Comment on lines
+100
to
+106
| if (this.configurationProviders.has(provider.handle)) { | ||
| const configuration = this.configurationProviders.get(provider.handle); | ||
| if (configuration && configuration.type !== provider.type) { | ||
| console.warn(`Different debug configuration provider with type '${configuration.type}' already registered.`); | ||
| provider.handle = this.configurationProviders.size; | ||
| } | ||
| } |
There was a problem hiding this comment.
Different way of solving it is the approach from registerDebugAdapterContribution. Instead of assigning a new handle number we can return Disposable.NULL
1 task
thegecko
approved these changes
Dec 20, 2023
planger
approved these changes
Dec 21, 2023
|
@thegecko If you merge now, it is the todays release :-) |
arekzaluski
added a commit
to ARMmbed/theia
that referenced
this pull request
Dec 22, 2023
…e-theia#13196) Signed-off-by: arekzaluski <arkadiusz.zaluski@arm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
This PR solves the problem when multiple plugins try to register debug configuration provider under the same handle number. Currently the old provider gets replaced. After this change the new number will be assigned.
Similar guard exists already in
registerDebugAdapterContributionHow to test
Follow-ups
Review checklist
Reminder for reviewers