Add a few vscode menu contribution points #13226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonah-iden
changed the title
msujew
added
vscode
msujew
changed the title
|
I would be happy to help for review here |
rschnekenbu
requested changes
Jan 11, 2024
There was a problem hiding this comment.
Thanks for your contribution, @jonah-iden!
I have some issues with the sample extension provided on vsx extensions and terminal titles, could you have a look?
packages/terminal/src/browser/terminal-frontend-contribution.ts
Outdated
Show resolved
Hide resolved
jonah-iden
force-pushed
the
jiden/add-vscode-contribution-points
branch
from
d508b5e
to
7e47b82
Compare
rschnekenbu
reviewed
Feb 26, 2024
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
…tion points Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
…mands Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
rschnekenbu
approved these changes
Feb 27, 2024
jonah-iden
force-pushed
the
jiden/add-vscode-contribution-points
branch
from
d4ea32a
to
1f7f778
Compare
This was referenced Feb 29, 2024
This was referenced Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
implements parts of #13051
specificly:
since Theias terminals are there own tabs, the last contribution is implemented when right clicking on the tab title.
The others should be at the same place they are in vscode
How to test
Here is a test extension (inlucluding vsix) which adds a menu entry to all of theias missing contribution points.
extension/contextcan be found when clicking the cog wheel (or right clicking) on an extension in the Extension widgetterminal/contextcan be found when right clicking inside a terminalterminal/title/contextcan be found when right clicking the tab title of a terminalim not too happy with having the menu path
['extensions_context_menu', '3_contribution']duplicated. If you have an idea where to place the constant for this i'd be happy to implement it.Follow-ups
Review checklist
Reminder for reviewers