Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Localization for the removeSession method (#12874) #13257

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

dhuebner
Copy link
Contributor

Add a missing signing out localization for the removeSession method as described in #12874

@msujew msujew added the localization issues related to localization/internalization/nls label Jan 10, 2024
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me 👍

@msujew msujew merged commit c487054 into eclipse-theia:master Jan 10, 2024
14 checks passed
@dhuebner dhuebner deleted the huebner/nls-12874 branch January 11, 2024 10:36
@dhuebner
Copy link
Contributor Author

@msujew
Could you also close #12874 please?

@msujew msujew linked an issue Jan 11, 2024 that may be closed by this pull request
@jfaltermeier jfaltermeier added this to the 1.46.0 milestone Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
localization issues related to localization/internalization/nls
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

nls: add missing removeSession localization when signing out
3 participants