Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove git Theia extension from examples #13274

Merged
merged 4 commits into from
May 8, 2024

Conversation

JonasHelming
Copy link
Contributor

related to #12745

What it does

Removes the Theia git extension from the example applications to prepare the deprecation (see #12745)

How to test

Build the examples, they should not include the Git Theia extension anymore.

Review checklist

Reminder for reviewers

Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JonasHelming Would it make sense to also remove the git plugins from the excluded plugins, so we still get git support in the example app?

@JonasHelming
Copy link
Contributor Author

Absolutly, where is the exclude defined?

@msujew
Copy link
Member

msujew commented Jan 16, 2024

@JonasHelming These two entries in particular:

theia/package.json

Lines 114 to 115 in a6d7e9b

"vscode.git",
"vscode.git-base",

@JonasHelming
Copy link
Contributor Author

Thanks, I tested git in the example app (browser) and it showed correctly for me (the VS Code built-in)

@msujew
Copy link
Member

msujew commented Jan 23, 2024

The changes look good, but for some reason the browser tests fail. Do they somehow rely on the @theia/git extension?

@JonasHelming JonasHelming marked this pull request as draft January 30, 2024 15:29
@JonasHelming JonasHelming force-pushed the GH-12745-remove-from-examples branch 4 times, most recently from 47cd9eb to a50645c Compare February 23, 2024 20:45
@tsmaeder
Copy link
Contributor

tsmaeder commented May 2, 2024

I'm having a look at this: likely, the difference is that the git extension is not automatically detecting git repos rooted in parent folders.

@tsmaeder tsmaeder marked this pull request as ready for review May 5, 2024 07:37
@tsmaeder tsmaeder force-pushed the GH-12745-remove-from-examples branch from 045dc65 to 5a0666e Compare May 5, 2024 07:43
@tsmaeder
Copy link
Contributor

tsmaeder commented May 5, 2024

The typescript test fail because of the update to 1.88.1 of the built-in extensions. Once we have merged #13673, they should pass.

@JonasHelming
Copy link
Contributor Author

@tsmaeder Looks good to me, could you approve it?

@tsmaeder tsmaeder force-pushed the GH-12745-remove-from-examples branch from 66008f1 to da81ced Compare May 6, 2024 11:38
JonasHelming and others added 3 commits May 6, 2024 15:28
Contributed on behalf of ST Microelectronics

Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
@tsmaeder tsmaeder force-pushed the GH-12745-remove-from-examples branch 2 times, most recently from 78b2c18 to 7ffe65d Compare May 7, 2024 12:14
Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
@tsmaeder tsmaeder force-pushed the GH-12745-remove-from-examples branch from 7ffe65d to 3300830 Compare May 7, 2024 12:57
@tsmaeder
Copy link
Contributor

tsmaeder commented May 7, 2024

@JonasHelming probably a good idea if you have a look over the changes I made to make the tests pass.

Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as well 👍

@msujew msujew added the git issues related to git label May 7, 2024
@JonasHelming JonasHelming merged commit ea87347 into master May 8, 2024
14 checks passed
@github-actions github-actions bot added this to the 1.50.0 milestone May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
git issues related to git
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants