-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove git Theia extension from examples #13274
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JonasHelming Would it make sense to also remove the git plugins from the excluded plugins, so we still get git support in the example app?
Absolutly, where is the exclude defined? |
@JonasHelming These two entries in particular: Lines 114 to 115 in a6d7e9b
|
40e93b9
to
287ff1c
Compare
Thanks, I tested git in the example app (browser) and it showed correctly for me (the VS Code built-in) |
The changes look good, but for some reason the browser tests fail. Do they somehow rely on the |
47cd9eb
to
a50645c
Compare
a50645c
to
045dc65
Compare
I'm having a look at this: likely, the difference is that the git extension is not automatically detecting git repos rooted in parent folders. |
045dc65
to
5a0666e
Compare
The typescript test fail because of the update to 1.88.1 of the built-in extensions. Once we have merged #13673, they should pass. |
@tsmaeder Looks good to me, could you approve it? |
66008f1
to
da81ced
Compare
Contributed on behalf of ST Microelectronics Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
78b2c18
to
7ffe65d
Compare
Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
7ffe65d
to
3300830
Compare
@JonasHelming probably a good idea if you have a look over the changes I made to make the tests pass. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me as well 👍
related to #12745
What it does
Removes the Theia git extension from the example applications to prepare the deprecation (see #12745)
How to test
Build the examples, they should not include the Git Theia extension anymore.
Review checklist
Reminder for reviewers